[webkit-changes] [WebKit/WebKit] 11b527: REGRESSION: WebGL shader linking error with Metal ...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11b5279aec6113c661dac368e2fc015fbc598f9c
      https://github.com/WebKit/WebKit/commit/11b5279aec6113c661dac368e2fc015fbc598f9c
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M Source/ThirdParty/ANGLE/src/compiler/translator/Types.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/msl/EmitMetal.cpp
    M Source/ThirdParty/ANGLE/src/compiler/translator/msl/ProgramPrelude.cpp
    M Source/ThirdParty/ANGLE/src/tests/gl_tests/GLSLTest.cpp

  Log Message:
  -----------
  REGRESSION: WebGL shader linking error with Metal backend when mixing scalar with vector
https://bugs.webkit.org/show_bug.cgi?id=283576
rdar://140546518

Reviewed by Kimmo Kinnunen.

Update the arithmetic helpers that handle UB to support operations between scalars and vectors.

* Source/ThirdParty/ANGLE/src/compiler/translator/Types.h:
(sh::TType::isSignedInt const):
(sh::TType::isSignedIntegerValue const): Deleted.
* Source/ThirdParty/ANGLE/src/compiler/translator/msl/EmitMetal.cpp:
(GetOperatorString):
(GenMetalTraverser::visitBinary):
* Source/ThirdParty/ANGLE/src/compiler/translator/msl/ProgramPrelude.cpp:
(PROGRAM_PRELUDE_DECLARE):
* Source/ThirdParty/ANGLE/src/tests/gl_tests/GLSLTest.cpp:

Canonical link: https://commits.webkit.org/287588@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications