[webkit-changes] [WebKit/WebKit] 79bda7: Adopt standards renames for declarative web push, ...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79bda7ce145cbd5c2e4b786e82920e9e587a37cd
      https://github.com/WebKit/WebKit/commit/79bda7ce145cbd5c2e4b786e82920e9e587a37cd
  Author: Brady Eidson <beidson at apple.com>
  Date:   2024-12-08 (Sun, 08 Dec 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Modules/notifications/Notification.cpp
    M Source/WebCore/Modules/notifications/Notification.h
    M Source/WebCore/Modules/notifications/Notification.idl
    M Source/WebCore/Modules/notifications/NotificationData.cpp
    M Source/WebCore/Modules/notifications/NotificationData.h
    M Source/WebCore/Modules/notifications/NotificationDataCocoa.mm
    M Source/WebCore/Modules/notifications/NotificationOptions.idl
    M Source/WebCore/Modules/notifications/NotificationPayload.cpp
    M Source/WebCore/Modules/push-api/PushEvent.cpp
    M Source/WebCore/Modules/push-api/PushEvent.h
    M Source/WebCore/Modules/push-api/PushEvent.idl
    R Source/WebCore/Modules/push-api/PushNotificationEvent.cpp
    R Source/WebCore/Modules/push-api/PushNotificationEvent.h
    R Source/WebCore/Modules/push-api/PushNotificationEvent.idl
    R Source/WebCore/Modules/push-api/PushNotificationEventInit.h
    R Source/WebCore/Modules/push-api/PushNotificationEventInit.idl
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
    M Source/WebCore/dom/EventInterfaces.in
    M Source/WebCore/page/WorkerNavigator.cpp
    M Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
    M Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
    M Source/WebCore/workers/service/ServiceWorkerRegistration.cpp
    M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
    M Source/WebCore/workers/service/context/ServiceWorkerThread.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  Adopt standards renames for declarative web push, and enable it
rdar://141082392
https://bugs.webkit.org/show_bug.cgi?id=284214

Reviewed by Per Arne Vollan.

Recent edits to the standards PRs have renamed a property, and moved some properties from
a new type of push event object onto the existing PushEvent.

Adopt those changes and enable.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/notifications/Notification.cpp:
(WebCore::Notification::create):
(WebCore::Notification::Notification):
(WebCore::Notification::data const):
* Source/WebCore/Modules/notifications/Notification.h:
* Source/WebCore/Modules/notifications/Notification.idl:
* Source/WebCore/Modules/notifications/NotificationData.cpp:
(WebCore::NotificationData::isolatedCopy const):
(WebCore::NotificationData::isolatedCopy):
* Source/WebCore/Modules/notifications/NotificationData.h:
* Source/WebCore/Modules/notifications/NotificationDataCocoa.mm:
(WebCore::NotificationData::dictionaryRepresentation const):
* Source/WebCore/Modules/notifications/NotificationOptions.idl:
* Source/WebCore/Modules/notifications/NotificationPayload.cpp:
(WebCore::NotificationPayload::fromNotificationData):
(WebCore::NotificationPayload::toNotificationData const):
* Source/WebCore/Modules/push-api/PushEvent.cpp:
(WebCore::PushEvent::create):
(WebCore::PushEvent::PushEvent):
(WebCore::PushEvent::notification):
(WebCore::PushEvent::appBadge):
(WebCore::PushEvent::updatedNotificationData const):
* Source/WebCore/Modules/push-api/PushEvent.h:
* Source/WebCore/Modules/push-api/PushEvent.idl:
* Source/WebCore/Modules/push-api/PushNotificationEvent.cpp: Removed.
* Source/WebCore/Modules/push-api/PushNotificationEvent.h: Removed.
* Source/WebCore/Modules/push-api/PushNotificationEvent.idl: Removed.
* Source/WebCore/Modules/push-api/PushNotificationEventInit.h: Removed.
* Source/WebCore/Modules/push-api/PushNotificationEventInit.idl: Removed.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/dom/EventInterfaces.in:
* Source/WebCore/page/WorkerNavigator.cpp:
(WebCore::WorkerNavigator::setAppBadge):
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::dispatchPushEvent):
(WebCore::ServiceWorkerGlobalScope::dispatchDeclarativePushEvent):
(WebCore::ServiceWorkerGlobalScope::clearDeclarativePushEvent):
(WebCore::ServiceWorkerGlobalScope::dispatchPushNotificationEvent): Deleted.
(WebCore::ServiceWorkerGlobalScope::clearPushNotificationEvent): Deleted.
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.h:
* Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::showNotification):
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFirePushEvent):
(WebCore::ServiceWorkerThread::queueTaskToFireDeclarativePushEvent):
(WebCore::ServiceWorkerThread::queueTaskToFirePushNotificationEvent): Deleted.
* Source/WebCore/workers/service/context/ServiceWorkerThread.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _processWebCorePersistentNotificationClick:completionHandler:]):

Canonical link: https://commits.webkit.org/287525@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications