[webkit-changes] [WebKit/WebKit] aa50d2: GraphicsContextState::mergeLastChanges spends time...

mattwoodrow noreply at github.com
Sun Dec 8 16:12:07 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa50d27385a2533501f99bd7533d21912725e023
      https://github.com/WebKit/WebKit/commit/aa50d27385a2533501f99bd7533d21912725e023
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-12-08 (Sun, 08 Dec 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/GraphicsContext.h
    M Source/WebCore/platform/graphics/GraphicsContextState.cpp
    M Source/WebCore/platform/graphics/GraphicsContextState.h
    M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
    M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h

  Log Message:
  -----------
  GraphicsContextState::mergeLastChanges spends time figuring out which bit changed.
https://bugs.webkit.org/show_bug.cgi?id=284138
<rdar://141014221>

Reviewed by Dan Glastonbury.

Add a new didUpdateSingleState virtual so that the index of the change (computed
at compile time) can be passed through to the merge function.

* Source/WebCore/platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::setFillBrush):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::setFillGradient):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setStrokeBrush):
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setStrokeThickness):
(WebCore::GraphicsContext::setStrokeStyle):
(WebCore::GraphicsContext::setDropShadow):
(WebCore::GraphicsContext::clearDropShadow):
(WebCore::GraphicsContext::setStyle):
(WebCore::GraphicsContext::setCompositeMode):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::setTextDrawingMode):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::setShouldAntialias):
(WebCore::GraphicsContext::setShouldSmoothFonts):
(WebCore::GraphicsContext::setShouldSubpixelQuantizeFonts):
(WebCore::GraphicsContext::setShadowsIgnoreTransforms):
(WebCore::GraphicsContext::setDrawLuminanceMask):
(WebCore::GraphicsContext::setUseDarkAppearance):
(WebCore::GraphicsContext::didUpdateSingleState):
* Source/WebCore/platform/graphics/GraphicsContextState.cpp:
(WebCore::GraphicsContextState::mergeLastChanges):
(WebCore::GraphicsContextState::mergeSingleChange):
(WebCore::toIndex): Deleted.
* Source/WebCore/platform/graphics/GraphicsContextState.h:
(WebCore::GraphicsContextState::ChangeIndex::toChange):
(WebCore::GraphicsContextState::toIndex):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawFilteredImageBuffer):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:

Canonical link: https://commits.webkit.org/287524@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list