[webkit-changes] [WebKit/WebKit] cb22ab: Cut unneeded includes from Lock.h, PersistentCoder...

Fri Dec 6 07:43:13 PST 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb22abbf151d2a3806fd116562b310fd73ae98a2
      https://github.com/WebKit/WebKit/commit/cb22abbf151d2a3806fd116562b310fd73ae98a2
  Author: Darin Adler <darin at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/API/JSContextRef.cpp
    M Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp
    M Source/JavaScriptCore/inspector/ConsoleMessage.h
    M Source/JavaScriptCore/inspector/ScriptFunctionCall.h
    M Source/JavaScriptCore/jsc.cpp
    M Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.h
    M Source/JavaScriptCore/profiler/ProfilerBytecodes.h
    M Source/JavaScriptCore/profiler/ProfilerEvent.cpp
    M Source/JavaScriptCore/profiler/ProfilerEvent.h
    M Source/JavaScriptCore/profiler/ProfilerOSRExit.h
    M Source/JavaScriptCore/profiler/ProfilerOSRExitSite.h
    M Source/JavaScriptCore/profiler/ProfilerOrigin.h
    M Source/JavaScriptCore/profiler/ProfilerOriginStack.h
    M Source/JavaScriptCore/profiler/ProfilerUID.h
    M Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.h
    M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
    M Source/JavaScriptCore/runtime/SamplingProfiler.cpp
    M Source/JavaScriptCore/runtime/SamplingProfiler.h
    M Source/JavaScriptCore/runtime/VM.cpp
    M Source/JavaScriptCore/runtime/VM.h
    M Source/WTF/wtf/Forward.h
    M Source/WTF/wtf/HashMap.h
    M Source/WTF/wtf/Lock.h
    M Source/WTF/wtf/MediaTime.cpp
    M Source/WTF/wtf/MediaTime.h
    M Source/WTF/wtf/Seconds.h
    M Source/WTF/wtf/SystemTracing.h
    M Source/WTF/wtf/ThreadingPrimitives.h
    M Source/WTF/wtf/WallTime.h
    M Source/WTF/wtf/persistence/PersistentCoders.cpp
    M Source/WTF/wtf/persistence/PersistentCoders.h
    M Source/WTF/wtf/persistence/PersistentDecoder.h
    M Source/WTF/wtf/persistence/PersistentEncoder.h
    M Source/WTF/wtf/posix/ThreadingPOSIX.cpp
    M Source/WTF/wtf/win/ThreadingWin.cpp
    M Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp
    M Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp
    M Source/WebCore/platform/PasteboardCustomData.cpp
    M Source/WebCore/platform/SharedBuffer.cpp
    M Source/WebCore/platform/WebCorePersistentCoders.cpp
    M Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm
    M Source/WebCore/platform/graphics/InbandGenericCue.cpp
    M Source/WebCore/platform/graphics/PlatformTimeRanges.cpp
    M Source/WebCore/platform/graphics/PlatformTimeRanges.h
    M Source/WebCore/platform/graphics/adwaita/Adwaita.h
    M Source/WebCore/platform/graphics/cocoa/CMUtilities.h
    M Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.h
    M Source/WebCore/platform/graphics/egl/GLFenceEGL.cpp
    M Source/WebCore/platform/graphics/egl/GLFenceEGL.h
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
    M Source/WebCore/platform/ios/LegacyTileLayerPool.h
    M Source/WebCore/platform/network/ResourceResponseBase.cpp
    M Source/WebCore/platform/network/curl/CookieJarDB.cpp
    M Source/WebCore/platform/network/curl/CookieJarDB.h
    M Source/WebCore/storage/StorageUtilities.cpp
    M Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp
    M Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp
    M Source/WebKit/NetworkProcess/Classifier/ITPThirdPartyDataForSpecificFirstParty.cpp
    M Source/WebKit/NetworkProcess/Classifier/ITPThirdPartyDataForSpecificFirstParty.h
    M Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp
    M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    M Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp
    M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm

  Log Message:
  -----------
  Cut unneeded includes from Lock.h, PersistentCoder.h, ThreadingPrimitives.h
https://bugs.webkit.org/show_bug.cgi?id=280570
rdar://136895761

Reviewed by Simon Fraser.

* Source/JavaScriptCore/API/JSContextRef.cpp:
(JSContextGroupTakeSamplesFromSamplingProfiler): Use
takeSamplingProfilerSamplesAsJSONString.

* Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp: Updated includes.
* Source/JavaScriptCore/inspector/ConsoleMessage.h: Ditto.
* Source/JavaScriptCore/inspector/ScriptFunctionCall.h: Ditto.

* Source/JavaScriptCore/jsc.cpp:
(functionSamplingProfilerStackTraces): Use stackTracesAsJSONString.

* Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.h: Ditto.
* Source/JavaScriptCore/profiler/ProfilerBytecodes.h: Ditto.
* Source/JavaScriptCore/profiler/ProfilerEvent.cpp: Ditto.
* Source/JavaScriptCore/profiler/ProfilerEvent.h: Ditto.
* Source/JavaScriptCore/profiler/ProfilerOSRExit.h: Ditto.
* Source/JavaScriptCore/profiler/ProfilerOSRExitSite.h: Ditto.
* Source/JavaScriptCore/profiler/ProfilerOrigin.h: Ditto.
* Source/JavaScriptCore/profiler/ProfilerOriginStack.h: Ditto.
* Source/JavaScriptCore/profiler/ProfilerUID.h: Ditto.
* Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.h: Ditto.

* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::dumpAndClearSamplingProfilerSamples): Use
takeSamplingProfilerSamplesAsJSONString.

* Source/JavaScriptCore/runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::stackTracesAsJSONString): Updated to return
a String. Both callers needed that version, and this prevents us from
having to depend on JSON types in SamplingProfiler.h, which is especially
bad because they can't be forward declared easily due to namespace shenanigans.
* Source/JavaScriptCore/runtime/SamplingProfiler.h: Ditto.

* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::takeSamplingProfilerSamplesAsJSONString): Updated to return
a String. Both callers needed that version, and this prevents us from
having to depend on JSON types in VM.h, which is especially bad because
they can't be forward declared easily due to namespace shenanigans.
* Source/JavaScriptCore/runtime/VM.h: Ditto.

* Source/WTF/wtf/Forward.h: Added using for Seconds and WallTime.

* Source/WTF/wtf/HashMap.h: Updated includes.
* Source/WTF/wtf/Lock.h: Ditto.

* Source/WTF/wtf/MediaTime.cpp:
(WTF::MediaTime::createFromSeconds): Moved from header.
(WTF::LogArgument<MediaTime>::toString): Moved from header.
(WTF::LogArgument<MediaTimeRange>::toString): Ditto.

* Source/WTF/wtf/MediaTime.h: Updated includes and moved functions that
depend on JSONValues.h and Seconds.h out of the header.

* Source/WTF/wtf/Seconds.h: Updated includes.
* Source/WTF/wtf/SystemTracing.h: Ditto.
* Source/WTF/wtf/ThreadingPrimitives.h: Ditto.
* Source/WTF/wtf/WallTime.h: Ditto.

* Source/WTF/wtf/persistence/PersistentCoders.cpp:
(WTF::Persistence::Coder<SHA1::Digest>::encodeForPersistence): Deleted.
(WTF::Persistence::Coder<SHA1::Digest>::decodeForPersistence): Deleted.

* Source/WTF/wtf/persistence/PersistentCoders.h: Updated includes.
To avoid depending on SHA1.h, made a coder for arrays of int8_t
rather than specifically for SHA1::Digest.

* Source/WTF/wtf/persistence/PersistentDecoder.h: Updated includes.
* Source/WTF/wtf/persistence/PersistentEncoder.h: Ditto.
* Source/WTF/wtf/posix/ThreadingPOSIX.cpp: Ditto.
* Source/WTF/wtf/win/ThreadingWin.cpp: Ditto.
* Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp: Ditto.
* Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp: Ditto.
* Source/WebCore/platform/PasteboardCustomData.cpp: Ditto.
* Source/WebCore/platform/SharedBuffer.cpp: Ditto.
* Source/WebCore/platform/WebCorePersistentCoders.cpp: Ditto.
* Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm: Ditto.
* Source/WebCore/platform/graphics/InbandGenericCue.cpp: Ditto.

* Source/WebCore/platform/graphics/PlatformTimeRanges.cpp:
(WTF::LogArgument<WebCore::PlatformTimeRanges>::toString): Moved from header.
* Source/WebCore/platform/graphics/PlatformTimeRanges.h: Moved toString out
of header so it can be compiled without including the String class.

* Source/WebCore/platform/graphics/adwaita/Adwaita.h: Updated includes.
* Source/WebCore/platform/graphics/cocoa/CMUtilities.h: Ditto.
* Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.h: Ditto.

* Source/WebCore/platform/graphics/egl/GLFenceEGL.cpp:
(WebCore::createEGLFence): Update conditional code to fix Windows build.
(WebCore::GLFenceEGL::GLFenceEGL): Ditto.
* Source/WebCore/platform/graphics/egl/GLFenceEGL.h: Ditto.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h: Ditto.
* Source/WebCore/platform/ios/LegacyTileLayerPool.h: Ditto.
* Source/WebCore/platform/network/ResourceResponseBase.cpp: Ditto.

* Source/WebCore/platform/network/curl/CookieJarDB.cpp:
(WebCore::CookieJarDB::searchCookies): Drive by fix: Dopped peculiar use of
const& for std::optional<bool>.
(WebCore::CookieJarDB::setCookie): Use overloading so the header doesn't need
to include Seconds.h.

* Source/WebCore/storage/StorageUtilities.cpp: Updated includes.
* Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp: Ditto.
* Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp: Ditto.
* Source/WebKit/NetworkProcess/Classifier/ITPThirdPartyDataForSpecificFirstParty.cpp: Ditto.
* Source/WebKit/NetworkProcess/Classifier/ITPThirdPartyDataForSpecificFirstParty.h: Ditto.
* Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp: Ditto.
* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp: Ditto.
* Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp: Ditto.
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp: Ditto.
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
* Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp: Ditto.
* Tools/TestWebKitAPI/Tests/WTF/Signals.cpp: Ditto.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm: Ditto.

Canonical link: https://commits.webkit.org/287449@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications