[webkit-changes] [WebKit/WebKit] 1e21ed: imported/w3c/web-platform-tests/navigation-api/nav...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e21ed7d927f52cff93c0630ece2b7288114ceee
      https://github.com/WebKit/WebKit/commit/1e21ed7d927f52cff93c0630ece2b7288114ceee
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-in-new-javascript-url-iframe-expected.txt
    M Source/WebCore/bindings/js/ScriptController.cpp

  Log Message:
  -----------
  imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-in-new-javascript-url-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=284051

Reviewed by Rob Buis.

When an iframe loads a JavaScript URL as first load, we would fail to create
a HistoryItem, even though we do commit a document. As a result,
navigation.entries would remain empty and the test would fail.

Fix this by making sure we create a HistoryItem when committing a JS URL, if
there is no current HistoryItem.

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-in-new-javascript-url-iframe-expected.txt:
* Source/WebCore/bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeJavaScriptURL):

Canonical link: https://commits.webkit.org/287448@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications