[webkit-changes] [WebKit/WebKit] 4309ab: [WebGPUSwift] re-implement copyTextureToTexture in...

[nmahendru]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4309ab042c6cdca3ed5e0cfe9230715b1ff62f5e
      https://github.com/WebKit/WebKit/commit/4309ab042c6cdca3ed5e0cfe9230715b1ff62f5e
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-12-05 (Thu, 05 Dec 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WTF/wtf/CMakeLists.txt
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/CommandEncoder.swift
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.swift

  Log Message:
  -----------
  [WebGPUSwift] re-implement copyTextureToTexture in Swift
https://bugs.webkit.org/show_bug.cgi?id=284044
rdar://140917930

Reviewed by Mike Wyrzykowski.

It's a 1-for-1 replacement.
Tested at desk with:

./LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyTextureToTexture.html <== Timeout(Same behavior as the non Swift implementation)
./LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyTextureToTexture.html <== PASS

Also, after discussing with Mike, adding `[ Release ] http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyTextureToTexture.html` to mac-wk2
as that test is actually working for non swift builds as well.

* Source/WTF/wtf/CMakeLists.txt:
* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::errorValidatingCopyTextureToTexture const):
(WebGPU::CommandEncoder::copyTextureToTexture):
(WebGPU::errorValidatingCopyTextureToTexture): Deleted.
* Source/WebGPU/WebGPU/CommandEncoder.swift:
(CommandEncoder_copyTextureToTexture_thunk(commandEncoder:source:destination:copySize:)):
(WebGPU.copyTextureToTexture(_:destination:copySize:)):
* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.swift:
(WebGPU.writeBuffer(_:bufferOffset:data:)):

Canonical link: https://commits.webkit.org/287423@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications