[webkit-changes] [WebKit/WebKit] 70b4f4: Video loses audio after entering light spill

Jean-Yves Avenard noreply at github.com
Thu Dec 5 18:32:48 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70b4f4295cbcc2c71152c8e42479c39386a41dfb
      https://github.com/WebKit/WebKit/commit/70b4f4295cbcc2c71152c8e42479c39386a41dfb
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-12-05 (Thu, 05 Dec 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.mm

  Log Message:
  -----------
  Video loses audio after entering light spill
rdar://140805541

Reviewed by Jer Noble.

In 286853 at main we switched to use an AVSampleBufferVideoRenderer if available
and use it on a workqueue.
However, it has since appeared that its use over multiple thread is broken (rdar://139910776)

For now, if we do not use a decompression session, only ever use the
renderer given on construction (either an AVSampleBufferVideoRenderer if in
light spill, or an AVSampleBufferDisplayLayer any other time) on the main thread.

If a decompression session is set, then we will only ever accessed the AVSampleBufferVideoRenderer
on our queue.

Manually tested.

* Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.mm:
(WebCore::VideoMediaSampleRenderer::~VideoMediaSampleRenderer):
(WebCore::VideoMediaSampleRenderer::maybeBecomeReadyForMoreMediaData):
(WebCore::VideoMediaSampleRenderer::stopRequestingMediaData):
(WebCore::VideoMediaSampleRenderer::resetReadyForMoreSample):

Canonical link: https://commits.webkit.org/287422@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list