[webkit-changes] [WebKit/WebKit] 90fa72: Remove RenderViewTransitionRoot.

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90fa725cb3fd45df96ecc656c2b95fc2aa9a47f3
      https://github.com/WebKit/WebKit/commit/90fa725cb3fd45df96ecc656c2b95fc2aa9a47f3
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/RenderView.cpp
    M Source/WebCore/rendering/RenderView.h
    R Source/WebCore/rendering/RenderViewTransitionRoot.cpp
    R Source/WebCore/rendering/RenderViewTransitionRoot.h
    M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp
    M Source/WebCore/style/Styleable.cpp

  Log Message:
  -----------
  Remove RenderViewTransitionRoot.
https://bugs.webkit.org/show_bug.cgi?id=284063
<rdar://140936851>

Reviewed by Tim Nguyen.

We should be able to create different renderers for view-transition pseudos
based on display type. The first step of that is removing
RenderViewTransitionRoot.

This moves the group hashtable onto RenderView instead, and creates
RenderBlockFlow for the root.

It also removes the IsViewTransitionContainer RenderBlockFlowFlag, since these
can be identified using the pseudo type from style instead of identifying the
renderer type.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isViewTransitionContainer const):
(WebCore::RenderObject::isViewTransitionPseudo const):
(WebCore::RenderObject::isRenderViewTransitionContainer const): Deleted.
(WebCore::RenderObject::isRenderViewTransitionRoot const): Deleted.
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::viewTransitionRoot const):
(WebCore::RenderView::setViewTransitionRoot):
(WebCore::RenderView::addViewTransitionGroup):
(WebCore::RenderView::removeViewTransitionGroup):
(WebCore::RenderView::viewTransitionGroupForName):
* Source/WebCore/rendering/RenderView.h:
* Source/WebCore/rendering/RenderViewTransitionRoot.cpp: Removed.
* Source/WebCore/rendering/RenderViewTransitionRoot.h: Removed.
* Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp:
(WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementTree):
(WebCore::createRendererIfNeeded):
(WebCore::RenderTreeUpdater::ViewTransition::buildPseudoElementGroup):
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::renderer const):

Canonical link: https://commits.webkit.org/287373@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications