[webkit-changes] [WebKit/WebKit] ce3d0f: [WebGPU] Validation layer reports an error when us...

mwyrzykowski noreply at github.com
Wed Dec 4 16:13:17 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce3d0fe96a044cb21831d23a0ad4099951d2958e
      https://github.com/WebKit/WebKit/commit/ce3d0fe96a044cb21831d23a0ad4099951d2958e
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm

  Log Message:
  -----------
  [WebGPU] Validation layer reports an error when using shared memory textures
https://bugs.webkit.org/show_bug.cgi?id=283467
rdar://140323587

Reviewed by Tadeu Zagallo.

Ensure ioSurface backed MTLTextures are allocated with MTLStorageModeManaged
as this is required on some Macs and MTLStorageModeManaged is always supported
on macOS.

Also align Intel graphics allocations with AMD, otherwise we see
asserts with validation enabled on Intel despite everything
seeming to work just fine on all Intel chips we support.

* Source/WebGPU/WebGPU/Device.h:
(WebGPU::Device::hasUnifiedMemory const):
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
Only create IOSurface backed textures with MTLStorageModeManaged, except
when unified memory and where WebGPU is enabled by default.

Canonical link: https://commits.webkit.org/287372@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list