[webkit-changes] [WebKit/WebKit] decff3: [EWS] checkout-pull-request handle empty commits

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: decff39e8b9d5550dd9b79ea5fa18b5b4628bf2a
      https://github.com/WebKit/WebKit/commit/decff39e8b9d5550dd9b79ea5fa18b5b4628bf2a
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2024-12-03 (Tue, 03 Dec 2024)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [EWS] checkout-pull-request handle empty commits
https://bugs.webkit.org/show_bug.cgi?id=283146

Reviewed by Jonathan Bedard.

By default, git-cherry-pick disallows cherry-picking an empty
commit. However, it's not unreasonable to submit a PR with an empty
commit where later commits gets squashed into it, especially when
there's benefit in preserving history for review.

Note that this _doesn't_ result in redundant commits (i.e., those
which have become empty due to an earlier commit) being allowed, it
only allows commits which were originally empty.

* Tools/CISupport/ews-build/steps.py:
(CheckOutPullRequest.run):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestCheckOutPullRequest.test_success):
(TestCheckOutPullRequest.test_success_apple):
(TestCheckOutPullRequest.test_success_integration_remote):
(TestCheckOutPullRequest.test_success_win):

Canonical link: https://commits.webkit.org/287296@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications