[webkit-changes] [WebKit/WebKit] a9abb7: [WASM] Default-initialized fields of WASM GC struc...

David Degazio noreply at github.com
Tue Dec 3 11:17:50 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a9abb749d5dadc02aba2f0fea2555558da06d117
      https://github.com/WebKit/WebKit/commit/a9abb749d5dadc02aba2f0fea2555558da06d117
  Author: David Degazio <d_degazio at apple.com>
  Date:   2024-12-03 (Tue, 03 Dec 2024)

  Changed paths:
    A JSTests/wasm/stress/struct-new_default-small-members.js
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp

  Log Message:
  -----------
  [WASM] Default-initialized fields of WASM GC struct should use Const32 if appropriate for storage type
https://bugs.webkit.org/show_bug.cgi?id=283941
rdar://140773922

Reviewed by Yusuke Suzuki and Keith Miller.

Generates a Const32Value in OMG instead of a Const64Value when
zero-initializing fields in struct.new_default when the field
storage types are 32-bit or smaller. This satisfies the B3
validator which expects an Int32 input for Stores of 32 bits or
smaller.

* JSTests/wasm/stress/struct-new_default-small-members.js: Added.
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::addStructNewDefault):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::addStructNewDefault):

Canonical link: https://commits.webkit.org/287295@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list