[webkit-changes] [WebKit/WebKit] cd77f7: Remove no longer spec'd color-contrast() support

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd77f75e6f7b8e708fa349e4b286bc790b9c1271
      https://github.com/WebKit/WebKit/commit/cd77f75e6f7b8e708fa349e4b286bc790b9c1271
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-08-29 (Thu, 29 Aug 2024)

  Changed paths:
    R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-contrast-001-expected.html
    R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-contrast-001.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency.html
    M LayoutTests/inspector/unit-tests/css-keyword-completions.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/parser/CSSParserContext.cpp
    M Source/WebCore/css/parser/CSSParserContext.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp

  Log Message:
  -----------
  Remove no longer spec'd color-contrast() support
https://bugs.webkit.org/show_bug.cgi?id=278864

Reviewed by Tim Nguyen.

`color-contrast()` has been removed from CSS Color 5. Fortunately,
we never turned it on by default, so we can just remove it.

There is a replacement planned in CSS Color 6 called `contrast-color()`,
but there is nothing to be shared.

* LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-contrast-001-expected.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-contrast-001.html: Removed.
    - Remove remaining test case, all others had been previously removed.

* LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency.html:
    - Fix error in title I noticed while grepping for "color-contrast".

* LayoutTests/inspector/unit-tests/css-keyword-completions.html:
    - Remove "color-contrast()" from set of completions.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
    - Remove color-contrast preference.

* Source/WebCore/css/CSSValueKeywords.in:
    - Remove keywords only used by "color-contrast()".

* Source/WebCore/css/parser/CSSParserContext.cpp:
* Source/WebCore/css/parser/CSSParserContext.h:
    - Remove setting for enabling color contrast.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAColorFunction):
(WebCore::CSSPropertyParserHelpers::selectFirstColorThatMeetsOrExceedsTargetContrast): Deleted.
(WebCore::CSSPropertyParserHelpers::selectFirstColorWithHighestContrast): Deleted.
(WebCore::CSSPropertyParserHelpers::consumeColorContrastFunction): Deleted.
(WebCore::CSSPropertyParserHelpers::consumeColorRawForLegacyColorContrast): Deleted.
    - Remove implementation of "color-contrast()".

Canonical link: https://commits.webkit.org/282921@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications