[webkit-changes] [WebKit/WebKit] db9e0f: GraphicsLayerWC shouldn't call GraphicsLayerClient...

Fujii Hironori noreply at github.com
Thu Aug 29 13:06:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db9e0f6f196db5f47df07fdf374a681ef86eab15
      https://github.com/WebKit/WebKit/commit/db9e0f6f196db5f47df07fdf374a681ef86eab15
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-08-29 (Thu, 29 Aug 2024)

  Changed paths:
    M LayoutTests/platform/win/TestExpectations
    M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp
    M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.h

  Log Message:
  -----------
  GraphicsLayerWC shouldn't call GraphicsLayerClient::notifyFlushRequired during layer flushing
https://bugs.webkit.org/show_bug.cgi?id=278847

Reviewed by Don Olmstead.

An assertion failed in RenderLayerCompositor::scheduleRenderingUpdate
for some SVG image tests. The assertion ensures
GraphicsLayerClient::notifyFlushRequired isn't called during layer
flushing. However, SVGImage does layout during painting.

Added a flag m_isFlushing to GraphicsLayerWC.

* LayoutTests/platform/win/TestExpectations:
* Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp:
(WebKit::GraphicsLayerWC::noteLayerPropertyChanged):
(WebKit::GraphicsLayerWC::flushCompositingStateForThisLayerOnly):
* Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.h:

Canonical link: https://commits.webkit.org/282920@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list