[webkit-changes] [WebKit/WebKit] ceb272: [Writing Tools] Send entire contents as context to...

Richard Robinson noreply at github.com
Wed Aug 28 13:09:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ceb2721f3072abc286af88e9d1f124e3cfc1fc03
      https://github.com/WebKit/WebKit/commit/ceb2721f3072abc286af88e9d1f124e3cfc1fc03
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/WebCore/page/writing-tools/WritingToolsController.mm
    M Source/WebCore/page/writing-tools/WritingToolsTypes.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/Cocoa/PlatformWritingToolsUtilities.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  [Writing Tools] Send entire contents as context to Writing Tools for Compose composition type
https://bugs.webkit.org/show_bug.cgi?id=278766
rdar://131875217

Reviewed by Abrar Rahman Protyasha.

For the Compose composition type sessions, send the entire range of the editable content instead
of just the enclosing paragraph(s).

* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::contextRangeForSession):
(WebCore::WritingToolsController::willBeginWritingToolsSession):
(WebCore::contextRangeForDocument): Deleted.
* Source/WebCore/page/writing-tools/WritingToolsTypes.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/Cocoa/PlatformWritingToolsUtilities.mm:
(WebKit::convertToWebCompositionSessionType):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, ShowAffordance)):
(TEST(WritingTools, CompositionWithComposeCompositionType)):

Canonical link: https://commits.webkit.org/282859@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list