[webkit-changes] [WebKit/WebKit] 9a62ea: [run-webkit-tests] introduce --add-baselines-to-pl...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a62ea99c1e322fc188e3b7738056899e39e5395
      https://github.com/WebKit/WebKit/commit/9a62ea99c1e322fc188e3b7738056899e39e5395
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
    M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
    M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py

  Log Message:
  -----------
  [run-webkit-tests] introduce --add-baselines-to-platform=PLATFORM_DIR
https://bugs.webkit.org/show_bug.cgi?id=270483
rdar://problem/124034416

Reviewed by Jonathan Bedard.

This provides the ability to generate baselines for a specified platform
directory (rather than the default, overriding the existing baseline, or
with --add-platform-exceptions into the most specific directory).

Along with this, add --add-redundant-platform-results, and change the
default to _not_ write new baselines if they are redundant (i.e., they
match something further up the baseline search path).

* Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner): Remove uneeded constants.
(SingleTestRunner._add_missing_baselines): Let _save_baseline_data compute paths.
(SingleTestRunner._location_for_new_baseline): Deleted.
(SingleTestRunner._overwrite_baselines): Let _save_baseline_data compute paths.
(SingleTestRunner._save_baseline_data):
Make this find the location itself, use TestResultWriter.expected_filename, optionally skip redundant results.
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Add new args; drive-by: add choice to other args so run-webkit-tests errors with invalid options
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RebaselineTest.test_new_baseline): Pass --add-redundant-platform-results as it tests they're written.
* Tools/Scripts/webkitpy/port/base.py:
(Port.baseline_version_dir): Correctly pass along device_type.
(Port.update_baseline): Deleted.

Canonical link: https://commits.webkit.org/282858@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications