[webkit-changes] [WebKit/WebKit] b133da: Remove the unused unrenderable inner border code i...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b133daba3fe55450c941f1468d8236529a7e9fdf
      https://github.com/WebKit/WebKit/commit/b133daba3fe55450c941f1468d8236529a7e9fdf
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-08-24 (Sat, 24 Aug 2024)

  Changed paths:
    M Source/WebCore/rendering/BorderPainter.cpp

  Log Message:
  -----------
  Remove the unused unrenderable inner border code in BorderPainter
https://bugs.webkit.org/show_bug.cgi?id=278606
rdar://134624276

Reviewed by Alan Baradlay.

In 256943 at main `RenderStyle::getRoundedInnerBorderFor()` was changed to fix up unrenderable inner borders, which is now
propagated into BorderShape. This means that the code in BorderPainter that checks for unrenderable inner borders is
never reached, so we can remove it.

I verified that no tests hit this code path, even ones intended to exercise this code
(css/css-backgrounds/inner-border-non-renderable.html, fast/borders/border-non-renderable-radius-inner-clip.html).

In future, we'll have BorderShape check for this state, and fall back to path-based clipping.

* Source/WebCore/rendering/BorderPainter.cpp:
(WebCore::BorderPainter::paintSides const):
(WebCore::BorderPainter::paintOneBorderSide const):
(WebCore::calculateAdjustedInnerBorder): Deleted.

Canonical link: https://commits.webkit.org/282705@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications