[webkit-changes] [WebKit/WebKit] d0527f: Remove MediaFormatReader

Sat Aug 24 15:24:34 PDT 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0527fca8fc20cdda907dfdc293323d7283bd262
      https://github.com/WebKit/WebKit/commit/d0527fca8fc20cdda907dfdc293323d7283bd262
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-08-24 (Sat, 24 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/media/media-vp8-hiddenframes.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WTF/wtf/PlatformEnableCocoa.h
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.cpp
    M Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h
    M Source/WebCore/PAL/pal/spi/cocoa/MediaToolboxSPI.h
    M Source/WebCore/page/DeprecatedGlobalSettings.h
    M Source/WebCore/platform/MediaSample.h
    M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
    M Source/WebCore/platform/audio/PlatformMediaSessionManager.h
    M Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParser.cpp
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h
    M Source/WebKit/Configurations/BaseXPCService.xcconfig
    R Source/WebKit/Configurations/MediaFormatReader.xcconfig
    M Source/WebKit/GPUProcess/GPUProcess.cpp
    M Source/WebKit/GPUProcess/GPUProcessPreferences.cpp
    M Source/WebKit/GPUProcess/GPUProcessPreferences.h
    M Source/WebKit/GPUProcess/GPUProcessPreferences.serialization.in
    M Source/WebKit/GPUProcess/mac/GPUProcessMac.mm
    R Source/WebKit/MediaFormatReaderPlugIn/Info.plist
    R Source/WebKit/MediaFormatReaderPlugIn/MediaFormatReaderPlugIn.cpp
    M Source/WebKit/Modules/OSX_Private.modulemap
    M Source/WebKit/Modules/iOS_Private.modulemap
    M Source/WebKit/PlatformMac.cmake
    R Source/WebKit/Shared/API/c/mac/WKMediaFormatReader.cpp
    R Source/WebKit/Shared/API/c/mac/WKMediaFormatReader.h
    R Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp
    R Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h
    R Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp
    R Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h
    R Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp
    R Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleByteRange.h
    R Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp
    R Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h
    R Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.cpp
    R Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.h
    M Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm

  Log Message:
  -----------
  Remove MediaFormatReader
https://bugs.webkit.org/show_bug.cgi?id=278596
rdar://134601520

Reviewed by Eric Carlson.

The MediaFormatReader plugin had been deprecated over the MediaPlayerPrivateWebM
a year ago. It was no longer tested.

Covered by existing tests.

* LayoutTests/TestExpectations:
* LayoutTests/media/media-vp8-hiddenframes.html: adjust fuzzing range for tests to pass on all platforms.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.cpp:
* Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h:
* Source/WebCore/PAL/pal/spi/cocoa/MediaToolboxSPI.h:
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setWebMFormatReaderEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::webMFormatReaderEnabled): Deleted.
* Source/WebCore/platform/MediaSample.h:
* Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::webMFormatReaderEnabled): Deleted.
(WebCore::PlatformMediaSessionManager::setWebMFormatReaderEnabled): Deleted.
* Source/WebCore/platform/audio/PlatformMediaSessionManager.h:
* Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
(WebCore::AVAssetMIMETypeCache::canDecodeExtendedType):
(WebCore::AVAssetMIMETypeCache::initializeCache):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::registerFormatReaderIfNecessary): Deleted.
(WebCore::willUseWebMFormatReaderForType): Deleted.
* Source/WebCore/platform/graphics/cocoa/SourceBufferParser.cpp:
(WebCore::SourceBufferParser::Segment::size const):
(WebCore::SourceBufferParser::Segment::read const):
(WebCore::SourceBufferParser::Segment::takeSharedBuffer):
(WebCore::SourceBufferParser::Segment::getData const):
(WebCore::SourceBufferParser::Segment::getSharedBuffer const): Deleted.
* Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h:
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::canLoadFormatReader): Deleted.
(WebCore::SourceBufferParserWebM::isWebMFormatReaderAvailable): Deleted.
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h:
* Source/WebKit/Configurations/BaseXPCService.xcconfig:
* Source/WebKit/Configurations/MediaFormatReader.xcconfig: Removed.
* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::updateGPUProcessPreferences):
* Source/WebKit/GPUProcess/GPUProcessPreferences.cpp:
(WebKit::GPUProcessPreferences::copyEnabledWebPreferences):
* Source/WebKit/GPUProcess/GPUProcessPreferences.h:
* Source/WebKit/GPUProcess/GPUProcessPreferences.serialization.in:
* Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::initializeProcess):
* Source/WebKit/MediaFormatReaderPlugIn/Info.plist: Removed.
* Source/WebKit/MediaFormatReaderPlugIn/MediaFormatReaderPlugIn.cpp: Removed.
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/PlatformMac.cmake:
* Source/WebKit/Shared/API/c/mac/WKMediaFormatReader.cpp: Removed.
* Source/WebKit/Shared/API/c/mac/WKMediaFormatReader.h: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleByteRange.h: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.cpp: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.cpp: Removed.
* Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.h: Removed.
* Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
* Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):

Canonical link: https://commits.webkit.org/282704@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications