[webkit-changes] [WebKit/WebKit] e466bf: Introduce a private WKWebViewConfiguration flag to...

Etienne Segonzac noreply at github.com
Tue Aug 20 00:35:51 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e466bf21b480e413f8d9d2220dc2b2bb9feb2d92
      https://github.com/WebKit/WebKit/commit/e466bf21b480e413f8d9d2220dc2b2bb9feb2d92
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

  Log Message:
  -----------
  Introduce a private WKWebViewConfiguration flag to control Overlay Regions
https://bugs.webkit.org/show_bug.cgi?id=278345
<rdar://133499543>

Reviewed by Mike Wyrzykowski.

Introduce a private WKWebViewConfiguration flag, defaulting to false,
to enable or disable Overlay Regions.

* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration _overlayRegionsEnabled]):
(-[WKWebViewConfiguration _setOverlayRegionsEnabled:]):
Declare the new property and add NSCoding support.

* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::overlayRegionsEnabled const):
(API::PageConfiguration::setOverlayRegionsEnabled):
Add getter/setter and storage for the flag.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _updateOverlayRegionsForCustomContentView]):
Gate the Overlay Regions updates on the new flag.

* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
Enable Overlay Regions in WebKitTestRunner.

Canonical link: https://commits.webkit.org/282485@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list