[webkit-changes] [WebKit/WebKit] 4605d7: Address additional API feedback for Web Extensions.

Timothy Hatcher noreply at github.com
Sun Aug 18 11:36:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4605d704512807f9780e15e1e2094e272b7f9337
      https://github.com/WebKit/WebKit/commit/4605d704512807f9780e15e1e2094e272b7f9337
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-08-18 (Sun, 18 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionAction.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionContext.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionController.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataRecord.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataRecord.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataType.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataType.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMatchPattern.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermission.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermissionPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataType.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDataRecordCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionMessagePort.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionDataRecord.mm

  Log Message:
  -----------
  Address additional API feedback for Web Extensions.
https://webkit.org/b/278191
rdar://problem/133988536

Reviewed by Jeff Miller.

Adjusted the property and method names for WKWebExtensionDataRecord APIs.
Added NS_SWIFT_NONISOLATED to all string symbols.
Tweaked the NS_SWIFT_NAME for all ErrorDomains.

* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionAction.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionContext.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionController.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionController.mm:
(+[WKWebExtensionController allExtensionDataTypes]):
(-[WKWebExtensionController removeDataOfTypes:fromDataRecords:completionHandler:]):
(-[WKWebExtensionController removeDataOfTypes:forDataRecords:completionHandler:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataRecord.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataRecord.mm:
(-[WKWebExtensionDataRecord containedDataTypes]):
(-[WKWebExtensionDataRecord totalSizeInBytes]):
(-[WKWebExtensionDataRecord sizeInBytesOfTypes:]):
(-[WKWebExtensionDataRecord dataTypes]): Deleted.
(-[WKWebExtensionDataRecord totalSize]): Deleted.
(-[WKWebExtensionDataRecord sizeOfDataTypes:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataType.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionDataType.mm:
(WebKit::toWebExtensionDataTypes):
(WebKit::toAPI):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMatchPattern.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionMessagePort.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermission.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermissionPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataType.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDataRecordCocoa.mm:
(WebKit::WebExtensionDataRecord::addError):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionDataRecord.mm:
(TestWebKitAPI::TEST(WKWebExtensionDataRecord, GetDataRecords)):
(TestWebKitAPI::TEST(WKWebExtensionDataRecord, GetDataRecordsForMultipleContexts)):
(TestWebKitAPI::TEST(WKWebExtensionDataRecord, DISABLED_RemoveDataRecords)):
(TestWebKitAPI::TEST(WKWebExtensionDataRecord, DISABLED_RemoveDataRecordsForMultipleContexts)):

Canonical link: https://commits.webkit.org/282402@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list