[webkit-changes] [WebKit/WebKit] b590c8: AX: Support the AXRangesForSearchPredicate API tha...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b590c842a3e221a9b0e9cb154c95676eb09b0da2
      https://github.com/WebKit/WebKit/commit/b590c842a3e221a9b0e9cb154c95676eb09b0da2
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-08-18 (Sun, 18 Aug 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXSearchManager.cpp
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  AX: Support the AXRangesForSearchPredicate API that VoiceOver uses to retrieve misspellings.
https://bugs.webkit.org/show_bug.cgi?id=278254
<rdar://problem/134083674>

Reviewed by Tyler Wilcock.

Follow up to https://github.com/WebKit/WebKit/pull/31136.

This functionality was originally implemented as an extension of the AXUIElementsForSearchPredicate API, but that didn't work for VoiceOver since it changes the type of the return value which is unexpected for the middleware system framework. Therfore, a new AXRangesForSearchPredicate API was added to expose the functionality on the Mac.

The corresponding AccessibilityUIElement::textMarkerRangeForSearchPredicate test method was updated.

* Source/WebCore/accessibility/AXSearchManager.cpp:
(WebCore::AXSearchManager::findMatchingRange):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::textMarkerRangeForSearchPredicate):

Canonical link: https://commits.webkit.org/282401@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications