[webkit-changes] [WebKit/WebKit] c00fdd: [text-box] Add support for text-box shorthand

Alan Baradlay noreply at github.com
Thu Aug 15 06:59:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c00fddd06efef22cbcb8d78a18f284f9aa5b993c
      https://github.com/WebKit/WebKit/commit/c00fddd06efef22cbcb8d78a18f284f9aa5b993c
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/ComputedStyleExtractor.h
    M Source/WebCore/css/ShorthandSerializer.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [text-box] Add support for text-box shorthand
https://bugs.webkit.org/show_bug.cgi?id=278042

Reviewed by Antti Koivisto and Tim Nguyen.

See https://drafts.csswg.org/css-inline-3/#text-box-shorthand

"This property is a shorthand for setting the text-box-trim and text-box-edge properties in a single declaration.

If the single keyword normal is specified, it sets text-box-trim to none and text-box-edge to auto. Otherwise, omitting the text-box-trim value sets it to both (not the initial value), while omitting the text-box-edge value sets it to auto (the initial value)."

* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::textBoxShorthandValue const):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/ComputedStyleExtractor.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeTextBoxShorthand):
(WebCore::CSSPropertyParser::parseShorthand):
* Source/WebCore/css/parser/CSSPropertyParser.h:

Canonical link: https://commits.webkit.org/282282@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list