[webkit-changes] [WebKit/WebKit] 732612: [GTK][WPE] WebProcessPool::sandboxEnabled() not al...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 732612dd32452136a00c102376adcc6549f5be0c
      https://github.com/WebKit/WebKit/commit/732612dd32452136a00c102376adcc6549f5be0c
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp

  Log Message:
  -----------
  [GTK][WPE] WebProcessPool::sandboxEnabled() not always consistent
https://bugs.webkit.org/show_bug.cgi?id=278158

Reviewed by Adrian Perez de Castro.

We decide whether to enabled sandbox or not when launching the process,
so that sandbox can be enabled in WebProcessPool but we still disable it
because we are running under valgrind or it's been disabled by an env
var. We should decide whether to enable the sandbox or nor in
WebProcessPool and then when launching the process just check the
launch options.

* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
(WebKit::isSandboxEnabled): Deleted.
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::setSandboxEnabled):

Canonical link: https://commits.webkit.org/282281@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications