[webkit-changes] [WebKit/WebKit] 4ef46f: [Writing Tools] Remove unnecessary infrastructure ...

Richard Robinson noreply at github.com
Tue Aug 13 16:32:36 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ef46f4e4c9551d4f25abb4d564e16bb0c2fe9d9
      https://github.com/WebKit/WebKit/commit/4ef46f4e4c9551d4f25abb4d564e16bb0c2fe9d9
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M Source/WebCore/dom/DocumentMarker.h
    M Source/WebCore/page/ChromeClient.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebCore/page/writing-tools/WritingToolsController.h
    M Source/WebCore/page/writing-tools/WritingToolsController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
    M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h
    M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  [Writing Tools] Remove unnecessary infrastructure to support concurrent Writing Tools sessions
https://bugs.webkit.org/show_bug.cgi?id=277998
rdar://133726884

Reviewed by Aditya Keerthi.

There's no need to support multiple sessions, and doing so significantly increases the complexity of the code.

* Source/WebCore/dom/DocumentMarker.h:
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebCore::ChromeClient::proofreadingSessionUpdateStateForSuggestionWithID):
(WebCore::ChromeClient::removeTransparentMarkersForActiveWritingToolsSession):
(WebCore::ChromeClient::removeInitialTextAnimationForActiveWritingToolsSession):
(WebCore::ChromeClient::addInitialTextAnimationForActiveWritingToolsSession):
(WebCore::ChromeClient::addSourceTextAnimationForActiveWritingToolsSession):
(WebCore::ChromeClient::addDestinationTextAnimationForActiveWritingToolsSession):
(WebCore::ChromeClient::clearAnimationsForActiveWritingToolsSession):
(WebCore::ChromeClient::removeTransparentMarkersForSessionID): Deleted.
(WebCore::ChromeClient::removeInitialTextAnimation): Deleted.
(WebCore::ChromeClient::addInitialTextAnimation): Deleted.
(WebCore::ChromeClient::addSourceTextAnimation): Deleted.
(WebCore::ChromeClient::addDestinationTextAnimation): Deleted.
(WebCore::ChromeClient::clearAnimationsForSessionID): Deleted.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::writingToolsSessionDidReceiveAction):
(WebCore::Page::contextRangeForActiveWritingToolsSession const):
(WebCore::Page::showSelectionForActiveWritingToolsSession const):
(WebCore::Page::contextRangeForSessionWithID const): Deleted.
(WebCore::Page::showSelectionForWritingToolsSessionWithID const): Deleted.
* Source/WebCore/page/Page.h:
* Source/WebCore/page/writing-tools/WritingToolsController.h:
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::willBeginWritingToolsSession):
(WebCore::WritingToolsController::proofreadingSessionDidReceiveSuggestions):
(WebCore::WritingToolsController::proofreadingSessionDidUpdateStateForSuggestion):
(WebCore::WritingToolsController::showSelection const):
(WebCore::WritingToolsController::compositionSessionDidFinishReplacement):
(WebCore::WritingToolsController::compositionSessionDidReceiveTextWithReplacementRangeAsync):
(WebCore::WritingToolsController::compositionSessionDidReceiveTextWithReplacementRange):
(WebCore::WritingToolsController::writingToolsSessionDidReceiveAction<WritingTools::Session::Type::Proofreading>):
(WebCore::WritingToolsController::writingToolsSessionDidReceiveAction<WritingTools::Session::Type::Composition>):
(WebCore::WritingToolsController::writingToolsSessionDidReceiveAction):
(WebCore::WritingToolsController::didEndWritingToolsSession<WritingTools::Session::Type::Proofreading>):
(WebCore::WritingToolsController::didEndWritingToolsSession<WritingTools::Session::Type::Composition>):
(WebCore::WritingToolsController::didEndWritingToolsSession):
(WebCore::WritingToolsController::updateStateForSelectedSuggestionIfNeeded):
(WebCore::WritingToolsController::respondToUnappliedEditing):
(WebCore::WritingToolsController::respondToReappliedEditing):
(WebCore::WritingToolsController::activeSessionRange const):
(WebCore::WritingToolsController::currentState):
(WebCore::WritingToolsController::showOriginalCompositionForSession):
(WebCore::WritingToolsController::showRewrittenCompositionForSession):
(WebCore::WritingToolsController::restartCompositionForSession):
(WebCore::WritingToolsController::showSelectionForWritingToolsSessionWithID const): Deleted.
(WebCore::WritingToolsController::contextRangeForSessionWithID const): Deleted.
(WebCore::WritingToolsController::stateForSession): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView willBeginWritingToolsSession:requestContexts:]):
(-[WKWebView didEndWritingToolsSession:accepted:]):
(-[WKWebView _proofreadingSessionShowDetailsForSuggestionWithUUID:relativeToRect:]):
(-[WKWebView _proofreadingSessionUpdateState:forSuggestionWithUUID:]):
(-[WKWebView _enableSourceTextAnimationAfterElementWithID:]):
(-[WKWebView _enableFinalTextAnimationForElementWithID:]):
(-[WKWebView _proofreadingSessionWithUUID:showDetailsForSuggestionWithUUID:relativeToRect:]): Deleted.
(-[WKWebView _proofreadingSessionWithUUID:updateState:forSuggestionWithUUID:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebKit::PageClientImplCocoa::proofreadingSessionUpdateStateForSuggestionWithID):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::enableSourceTextAnimationAfterElementWithID):
(WebKit::WebPageProxy::enableTextAnimationTypeForElementWithID):
(WebKit::WebPageProxy::addTextAnimationForAnimationID):
(WebKit::WebPageProxy::showSelectionForActiveWritingToolsSession):
(WebKit::WebPageProxy::removeTextAnimationForAnimationID):
(WebKit::WebPageProxy::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebKit::WebPageProxy::proofreadingSessionUpdateStateForSuggestionWithID):
(WebKit::WebPageProxy::showSelectionForWritingToolsSessionAssociatedWithAnimationID): Deleted.
(WebKit::WebPageProxy::showSelectionForWritingToolsSessionWithID): Deleted.
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm:
(-[WKTextAnimationManager addTextAnimationForAnimationID:withData:]):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebKit::WebChromeClient::proofreadingSessionUpdateStateForSuggestionWithID):
(WebKit::WebChromeClient::removeTransparentMarkersForActiveWritingToolsSession):
(WebKit::WebChromeClient::removeInitialTextAnimationForActiveWritingToolsSession):
(WebKit::WebChromeClient::addInitialTextAnimationForActiveWritingToolsSession):
(WebKit::WebChromeClient::addSourceTextAnimationForActiveWritingToolsSession):
(WebKit::WebChromeClient::addDestinationTextAnimationForActiveWritingToolsSession):
(WebKit::WebChromeClient::clearAnimationsForActiveWritingToolsSession):
(WebKit::WebChromeClient::removeTransparentMarkersForSessionID): Deleted.
(WebKit::WebChromeClient::removeInitialTextAnimation): Deleted.
(WebKit::WebChromeClient::addInitialTextAnimation): Deleted.
(WebKit::WebChromeClient::addSourceTextAnimation): Deleted.
(WebKit::WebChromeClient::addDestinationTextAnimation): Deleted.
(WebKit::WebChromeClient::clearAnimationsForSessionID): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm:
(WebKit::TextAnimationController::unreplacedRangeForActiveWritingToolsSession const):
(WebKit::TextAnimationController::contextRangeForActiveWritingToolsSession const):
(WebKit::TextAnimationController::contextRangeForTextAnimationID const):
(WebKit::TextAnimationController::removeTransparentMarkersForActiveWritingToolsSession):
(WebKit::TextAnimationController::removeInitialTextAnimationForActiveWritingToolsSession):
(WebKit::TextAnimationController::addInitialTextAnimationForActiveWritingToolsSession):
(WebKit::TextAnimationController::addSourceTextAnimationForActiveWritingToolsSession):
(WebKit::TextAnimationController::addDestinationTextAnimationForActiveWritingToolsSession):
(WebKit::TextAnimationController::clearAnimationsForActiveWritingToolsSession):
(WebKit::TextAnimationController::enableSourceTextAnimationAfterElementWithID):
(WebKit::TextAnimationController::enableTextAnimationTypeForElementWithID):
(WebKit::TextAnimationController::unreplacedRangeForSessionWithID const): Deleted.
(WebKit::TextAnimationController::contextRangeForSessionWithID const): Deleted.
(WebKit::TextAnimationController::removeTransparentMarkersForSessionID): Deleted.
(WebKit::TextAnimationController::removeInitialTextAnimation): Deleted.
(WebKit::TextAnimationController::addInitialTextAnimation): Deleted.
(WebKit::TextAnimationController::addSourceTextAnimation): Deleted.
(WebKit::TextAnimationController::addDestinationTextAnimation): Deleted.
(WebKit::TextAnimationController::showSelectionForWritingToolsSessionAssociatedWithAnimationID): Deleted.
(WebKit::TextAnimationController::clearAnimationsForSessionID): Deleted.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::removeTransparentMarkersForActiveWritingToolsSession):
(WebKit::WebPage::removeInitialTextAnimationForActiveWritingToolsSession):
(WebKit::WebPage::addInitialTextAnimationForActiveWritingToolsSession):
(WebKit::WebPage::addSourceTextAnimationForActiveWritingToolsSession):
(WebKit::WebPage::addDestinationTextAnimationForActiveWritingToolsSession):
(WebKit::WebPage::clearAnimationsForActiveWritingToolsSession):
(WebKit::WebPage::enableSourceTextAnimationAfterElementWithID):
(WebKit::WebPage::enableTextAnimationTypeForElementWithID):
(WebKit::WebPage::showSelectionForActiveWritingToolsSession):
(WebKit::WebPage::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebKit::WebPage::proofreadingSessionUpdateStateForSuggestionWithID):
(WebKit::WebPage::removeTransparentMarkersForSessionID): Deleted.
(WebKit::WebPage::removeInitialTextAnimation): Deleted.
(WebKit::WebPage::addInitialTextAnimation): Deleted.
(WebKit::WebPage::addSourceTextAnimation): Deleted.
(WebKit::WebPage::addDestinationTextAnimation): Deleted.
(WebKit::WebPage::clearAnimationsForSessionID): Deleted.
(WebKit::WebPage::showSelectionForWritingToolsSessionAssociatedWithAnimationID): Deleted.
(WebKit::WebPage::showSelectionForWritingToolsSessionWithID): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/282207@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list