[webkit-changes] [WebKit/WebKit] 0eabc2: Fix 2 site isolation tests on Sequoia

Alex Christensen noreply at github.com
Tue Aug 13 16:30:38 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0eabc2e1a7d800ab699298dcb766d063de264f48
      https://github.com/WebKit/WebKit/commit/0eabc2e1a7d800ab699298dcb766d063de264f48
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Fix 2 site isolation tests on Sequoia
https://bugs.webkit.org/show_bug.cgi?id=278064
rdar://133796087

Reviewed by Sihui Liu.

The result of objectByEvaluatingJavaScript is already an NSString.
Calling the stringValue selector on it causes an ObjC exception on Sequoia.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, RunOpenPanel)):
(TestWebKitAPI::TEST(SiteIsolation, WebsitePoliciesCustomNavigatorPlatform)):

Canonical link: https://commits.webkit.org/282206@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list