[webkit-changes] [WebKit/WebKit] 1d2161: [Unified PDF] Discrete mode: super jittery scrolli...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d216164208b019064374ac2456e52b2391d704b
      https://github.com/WebKit/WebKit/commit/1d216164208b019064374ac2456e52b2391d704b
  Author: Tim Horton <thorton at apple.com>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [Unified PDF] Discrete mode: super jittery scrolling, document intermittently disappears altogether briefly
https://bugs.webkit.org/show_bug.cgi?id=278005
rdar://131934095

Reviewed by Abrar Rahman Protyasha.

In discrete mode, we use very specific and non-traditional scrolling physics for
swapping pages. This doesn't jive with rubber-banding, since when we hit the
transition between pages we stop abruptly, and peel the page away from the edge
in a layered manner when you push further.

Also, rubber-banding causes scroll offset chaos for some undiagnosed reason.

Given both reasons, disable rubber-banding in discrete mode.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::overscrollBehavior const):

Canonical link: https://commits.webkit.org/282156@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications