[webkit-changes] [WebKit/WebKit] 243516: [Debug] `fast/multicol/crash-in-vertical-writing-m...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 243516e30c68c79110e148fdfd5465bc036b2f58
      https://github.com/WebKit/WebKit/commit/243516e30c68c79110e148fdfd5465bc036b2f58
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/rendering/RenderMultiColumnFlow.cpp

  Log Message:
  -----------
  [Debug] `fast/multicol/crash-in-vertical-writing-mode.html` is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=277946

Reviewed by Alan Baradlay.

In some circumstances `RenderMultiColumnFlow::updateMinimumPageHeight()`
is being called when the fragments are still invalid and the asseration
`ASSERT(!m_fragmentsInvalidated)` is reached in
`RenderFragmentedFlow::fragmentAtBlockOffset()`.

To prevent this, we should check that
`RenderFragmentedFlow::hasValidFragmentInto()`.

This patch doesn't change the behaviour in the release build, but
prevents a crash in the debug build.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::updateMinimumPageHeight):

Canonical link: https://commits.webkit.org/282127@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications