[webkit-changes] [WebKit/WebKit] d2e80d: Move `tableLayout` from `NonInheritedFlags` to `St...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2e80d5126bbec051ee2d3e1d0a824fef8df3a58
      https://github.com/WebKit/WebKit/commit/d2e80d5126bbec051ee2d3e1d0a824fef8df3a58
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleMiscNonInheritedData.h

  Log Message:
  -----------
  Move `tableLayout` from `NonInheritedFlags` to `StyleMiscNonInheritedData`
https://bugs.webkit.org/show_bug.cgi?id=277064
rdar://132456969

Reviewed by Tim Nguyen.

In order to implement a new pseudo-element (::target-text), `pseudoBits` needs
to grow by one bit. However, this will result in increasing the overall size
of `NonInheritedFlags` and `RenderStyle`.

To avoid this, move `tableLayout` to `StyleMiscNonInheritedData`, freeing up a
bit in `NonInheritedFlags`.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyle.h:

Also move `hasContentNone` to ensure the free bit is available for use by
`pseudoBits`, which is at the end of `NonInheritedFlags`.

* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::tableLayout const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setTableLayout):
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp:
(WebCore::StyleMiscNonInheritedData::StyleMiscNonInheritedData):
(WebCore::StyleMiscNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.h:

Canonical link: https://commits.webkit.org/282126@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications