[webkit-changes] [WebKit/WebKit] 63be5c: [JSC] Simplify Megamorphic Inlining conditions

Yusuke Suzuki noreply at github.com
Fri Aug 9 15:15:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63be5cc1417667dc3ef4d63e89f38d639ad50861
      https://github.com/WebKit/WebKit/commit/63be5cc1417667dc3ef4d63e89f38d639ad50861
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-08-09 (Fri, 09 Aug 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/GetByStatus.cpp
    M Source/JavaScriptCore/bytecode/InByStatus.cpp
    M Source/JavaScriptCore/bytecode/InlineCallFrame.h
    M Source/JavaScriptCore/bytecode/PutByStatus.cpp

  Log Message:
  -----------
  [JSC] Simplify Megamorphic Inlining conditions
https://bugs.webkit.org/show_bug.cgi?id=277882
rdar://133562907

Reviewed by Keith Miller.

Originally this heuristics is introduced because our megamorphic cache has some lacking cases.
But now, this is well supported, and this complicated condition is no longer necessary much,
which does not affect on performance anymore. Let's remove and simplify things.

* Source/JavaScriptCore/bytecode/GetByStatus.cpp:
(JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback):
* Source/JavaScriptCore/bytecode/InByStatus.cpp:
(JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):
* Source/JavaScriptCore/bytecode/InlineCallFrame.h:
(JSC::isSameStyledCodeOrigin): Deleted.
* Source/JavaScriptCore/bytecode/PutByStatus.cpp:
(JSC::PutByStatus::computeForStubInfo):

Canonical link: https://commits.webkit.org/282061@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list