[webkit-changes] [WebKit/WebKit] 91e951: background-clip: text fails to paint text decorations

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91e95190faaa8209accdf4ac3863a06e1095796d
      https://github.com/WebKit/WebKit/commit/91e95190faaa8209accdf4ac3863a06e1095796d
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-08-09 (Fri, 09 Aug 2024)

  Changed paths:
    M LayoutTests/fast/text/text-decoration-currentcolor-fill-color-expected.html
    M LayoutTests/fast/text/text-decoration-currentcolor-fill-color.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-text-decorations-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-text-decorations-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-text-decorations.html
    M Source/WebCore/rendering/TextDecorationPainter.cpp

  Log Message:
  -----------
  background-clip: text fails to paint text decorations
https://bugs.webkit.org/show_bug.cgi?id=179334
rdar://93823895

Reviewed by Tim Nguyen.

Respect the ForceBlackText/ForceWhiteText PaintBehavior flags, which allows us to paint text decorations into
the `background-clip: text` mask, so they show up when that is used.

This change broke fast/text/text-decoration-currentcolor-fill-color.html, which was testing that text
decorations did *not* show with `background-clip: text`, although it was also testing that the inherited
`-webkit-text-fill-color: transparent` overrides the `color` on an anchor. So fix that test to reflect
what it was doing.

* LayoutTests/fast/text/text-decoration-currentcolor-fill-color-expected.html:
* LayoutTests/fast/text/text-decoration-currentcolor-fill-color.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-text-decorations-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-text-decorations-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-text-decorations.html: Added.
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::decorationColor):

Canonical link: https://commits.webkit.org/282060@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications