[webkit-changes] [WebKit/WebKit] 7f71d3: Add parsing support for `background-clip: border-a...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f71d31815a84515504ba6b38e379e2a1a6f0a44
      https://github.com/WebKit/WebKit/commit/7f71d31815a84515504ba6b38e379e2a1a6f0a44
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-08-09 (Fri, 09 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-invalid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-computed.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/parser/CSSParserContext.cpp
    M Source/WebCore/css/parser/CSSParserContext.h
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h

  Log Message:
  -----------
  Add parsing support for `background-clip: border-area`
https://bugs.webkit.org/show_bug.cgi?id=277842
rdar://133503570

Reviewed by Tim Nguyen.

Add parsing support for the new `border-area` value in `background-clip`[1]. There's a new keyword
in CSSValueKeywords.in, and a new value to the `FillBox` enum, and the relevant conversions.

Sadly we can't use generated code for parsing any more, because `background-clip` uses
a sub-grammar which doesn't support conditional keywords. I tried to fix the Python code
generation, but it's a non-trivial task.

Flip the setting to testable, and modify relevant WPT to test for this new value.

[1] https://drafts.csswg.org/css-backgrounds-4/#background-clip

* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-invalid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-clip-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-computed.html:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
(WebCore::fromCSSValueID):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeBackgroundComponent):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleBackgroundClip):
(WebCore::CSSPropertyParserHelpers::consumeBackgroundClip):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Canonical link: https://commits.webkit.org/282049@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications