[webkit-changes] [WebKit/WebKit] d6da26: [@page] Enable support for margin descriptors

Tim Nguyen noreply at github.com
Fri Aug 9 08:46:17 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6da262e8a08e049496bd731e598147054304839
      https://github.com/WebKit/WebKit/commit/d6da262e8a08e049496bd731e598147054304839
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-08-09 (Fri, 09 Aug 2024)

  Changed paths:
    M LayoutTests/printing/page-with-10mm-left-margin.html
    M LayoutTests/printing/page-with-zero-margin.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/page/PrintContext.cpp

  Log Message:
  -----------
  [@page] Enable support for margin descriptors
https://bugs.webkit.org/show_bug.cgi?id=265314
rdar://118773100

Reviewed by Alan Baradlay.

Enable the feature flag; per
https://bugs.webkit.org/show_bug.cgi?id=200039, "Alan says this should
be enabled in shipping branches", but this seemingly never happened.

Rename the flag, since the only feature actually behind it is
support for the margin descriptor for @page; the rest of @page is
unconditionally enabled.

* LayoutTests/printing/page-with-10mm-left-margin.html:
* LayoutTests/printing/page-with-zero-margin.html:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/page/PrintContext.cpp:
(WebCore::PrintContext::computedPageMargin):

Canonical link: https://commits.webkit.org/282048@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list