[webkit-changes] [WebKit/WebKit] f07a7c: [JSC] Remove VarargsLength and LoadVarargs when it...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f07a7ccd22b48a7b8c72388689a05d18139d4f51
      https://github.com/WebKit/WebKit/commit/f07a7ccd22b48a7b8c72388689a05d18139d4f51
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
    A JSTests/microbenchmarks/call-varargs-null.js
    A JSTests/stress/call-varargs-null-length.js
    A JSTests/stress/call-varargs-null.js
    M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
    M Source/JavaScriptCore/dfg/DFGClobberize.h
    M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  -----------
  [JSC] Remove VarargsLength and LoadVarargs when it gets undefined / null
https://bugs.webkit.org/show_bug.cgi?id=269162
rdar://122740130

Reviewed by Yijia Huang.

This patch adds OtherUse speculation to VarargsLength and LoadVarargs to optimize a bit, which will be used when null / undefined are passed to call_varargs.

                                  ToT                     Patched

    call-varargs-null        6.2067+-0.0196     ^      1.9197+-0.0109        ^ definitely 3.2331x faster

* JSTests/microbenchmarks/call-varargs-null.js: Added.
(test2):
(test):
* JSTests/stress/call-varargs-null-length.js: Added.
(shouldBe):
(test2):
(test):
* JSTests/stress/call-varargs-null.js: Added.
(test2):
(test):
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* Source/JavaScriptCore/dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

Canonical link: https://commits.webkit.org/281833@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications