[webkit-changes] [WebKit/WebKit] 0bcf16: Enable CryptoKit for all releases

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bcf166a295a09d48406bc93c5cbb5371877586b
      https://github.com/WebKit/WebKit/commit/0bcf166a295a09d48406bc93c5cbb5371877586b
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
    M LayoutTests/platform/ios-17/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-ventura/TestExpectations
    M Source/WebCore/Configurations/WebCore.xcconfig
    M Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp
    M Source/WebCore/PAL/Configurations/PAL.xcconfig
    M Tools/TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp

  Log Message:
  -----------
  Enable CryptoKit for all releases
https://bugs.webkit.org/show_bug.cgi?id=277432
rdar://132913336

Reviewed by Matthew Finkel.

Changing the enablement logic to enable by default and only skip
for platforms we don't want to. This will also fix the recurring problem of enabling
it in every release.
Also refactor the hardcoded enablement to constexpr instead of individual values as it makes
it easier to revert, just in case.

* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp:
(WebCore::AuthenticatorAttestationResponse::getPublicKey const):
* Source/WebCore/Modules/webauthn/fido/Pin.cpp:
* Source/WebCore/PAL/Configurations/PAL.xcconfig:
* Tools/TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp:
(TestWebKitAPI::TEST(CtapPinTest, TestSetPinRequest)):
(TestWebKitAPI::TEST(CtapPinTest, TestKeyAgreementResponse)):
(TestWebKitAPI::TEST(CtapPinTest, TestTokenRequest)):
* LayoutTests/platform/ios-17/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-ventura/TestExpectations:

Canonical link: https://commits.webkit.org/281832@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications