[webkit-changes] [WebKit/WebKit] 443e79: [UnifiedPDF] Callers should be able to plumb layou...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 443e796d1538654c34f2690e39600c70c8052b63
      https://github.com/WebKit/WebKit/commit/443e796d1538654c34f2690e39600c70c8052b63
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm

  Log Message:
  -----------
  [UnifiedPDF] Callers should be able to plumb layout row to AsyncPDFRenderer::pdfContentChangedInRect()
https://bugs.webkit.org/show_bug.cgi?id=277474
rdar://132965803

Reviewed by Sammy Gill.

Callers of AsyncPDFRenderer::pdfContentChangedInRect() are expected to be
aware of the layout row corresponding to the graphics layer (and the
changed content) they want to inform the renderer of. As such, it makes
sense to get rid of the extra work of having to look up a layout row
corresponding to a TiledBacking and instead have said data provided to us
by callers.

This patch achieves that by adding an optional LayoutRow argument to
pdfContentChangedInRect.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::AsyncPDFRenderer::pdfContentChangedInRect):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm:
(WebKit::PDFDiscretePresentationController::setNeedsRepaintInDocumentRect):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm:
(WebKit::PDFScrollingPresentationController::setNeedsRepaintInDocumentRect):

Canonical link: https://commits.webkit.org/281742@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications