[webkit-changes] [WebKit/WebKit] 33a3ef: [UnifiedPDF] (nearest)pageIndexForDocumentPoint() ...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33a3ef39eba7f26838ae68ffd4b96b91d34813c2
      https://github.com/WebKit/WebKit/commit/33a3ef39eba7f26838ae68ffd4b96b91d34813c2
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] (nearest)pageIndexForDocumentPoint() should be exposed through the presentation controller
https://bugs.webkit.org/show_bug.cgi?id=277473
rdar://132965195

Reviewed by Sammy Gill.

The PDFPresentationController class maintains our (visible) row state,
and as such it makes the most sense for callers to be able to query this
controller for the page index corresponding to a point.

This patch moves (nearest)pageIndexForDocumentPoint to the presentation
controller class and makes that possible.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm:
(WebKit::PDFPresentationController::nearestPageIndexForDocumentPoint const):
(WebKit::PDFPresentationController::pageIndexForDocumentPoint const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::didInvalidateDataDetectorHighlightOverlayRects):
(WebKit::UnifiedPDFPlugin::indexForCurrentPageInView const):
(WebKit::UnifiedPDFPlugin::annotationForRootViewPoint const):
(WebKit::UnifiedPDFPlugin::pdfElementTypesForPluginPoint const):
(WebKit::UnifiedPDFPlugin::handleMouseEvent):
(WebKit::UnifiedPDFPlugin::createContextMenu const):
(WebKit::UnifiedPDFPlugin::existingSelectionContainsPoint const):
(WebKit::UnifiedPDFPlugin::continueAutoscroll):
(WebKit::UnifiedPDFPlugin::performDictionaryLookupAtLocation):
(WebKit::UnifiedPDFPlugin::textForImmediateActionHitTestAtPoint):
(WebKit::UnifiedPDFPlugin::accessibilityHitTestIntPoint const):
(WebKit::UnifiedPDFPlugin::nearestPageIndexForDocumentPoint const): Deleted.
(WebKit::UnifiedPDFPlugin::pageIndexForDocumentPoint const): Deleted.

Canonical link: https://commits.webkit.org/281741@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications