[webkit-changes] [WebKit/WebKit] 8f6b6a: Rename SafeBrowsingWarning to BrowsingWarning

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f6b6a29cf4acbf08d9f6251c94eb2d8d3e0b0dc
      https://github.com/WebKit/WebKit/commit/8f6b6a29cf4acbf08d9f6251c94eb2d8d3e0b0dc
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
    A Source/WebKit/UIProcess/BrowsingWarning.h
    A Source/WebKit/UIProcess/Cocoa/BrowsingWarningCocoa.mm
    R Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/_WKWarningView.h
    M Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm
    M Source/WebKit/UIProcess/PageClient.h
    R Source/WebKit/UIProcess/SafeBrowsingWarning.h
    M Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp
    M Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h
    M Source/WebKit/UIProcess/WebFrameProxy.cpp
    M Source/WebKit/UIProcess/WebFrameProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
    M Source/WebKit/UIProcess/mac/PageClientImplMac.h
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Rename SafeBrowsingWarning to BrowsingWarning
https://bugs.webkit.org/show_bug.cgi?id=277500
rdar://133006339

Reviewed by Ryosuke Niwa.

Similar to 281715 at main. This change renames the SafeBrowsingWarning class to be
more generic. I left some of the variables as "safeBrowsingWarning" when that
correctly describes what they are.

No behavioral changes, covered by existing tests.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _showWarningView:completionHandler:]):
(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):
(-[WKWebView _showWarningViewWithURL:title:warning:detailsWithLinks:completionHandler:]):
(+[WKWebView _confirmMalwareSentinel]):
(+[WKWebView _visitUnsafeWebsiteSentinel]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/BrowsingWarning.h: Renamed from Source/WebKit/UIProcess/SafeBrowsingWarning.h.
(WebKit::BrowsingWarning::create):
* Source/WebKit/UIProcess/Cocoa/BrowsingWarningCocoa.mm: Renamed from Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm.
(WebKit::browsingTitleText):
(WebKit::browsingWarningText):
(WebKit::browsingDetailsText):
(WebKit::BrowsingWarning::BrowsingWarning):
(WebKit::BrowsingWarning::visitUnsafeWebsiteSentinel):
(WebKit::BrowsingWarning::confirmMalwareSentinel):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
* Source/WebKit/UIProcess/Cocoa/_WKWarningView.h:
* Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm:
(-[_WKWarningView initWithFrame:browsingWarning:completionHandler:]):
(-[_WKWarningView clickedOnLink:]):
(-[_WKWarningView initWithFrame:safeBrowsingWarning:completionHandler:]): Deleted.
* Source/WebKit/UIProcess/PageClient.h:
(WebKit::PageClient::showSafeBrowsingWarning):
* Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults):
* Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::showSafeBrowsingWarning):
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::showSafeBrowsingWarning):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::showWarningView):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/281728@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications