[webkit-changes] [WebKit/WebKit] a7320f: [css-grid] Improve GridTrackSizingAlgorithm Archit...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a7320ffab3aeadbd0b27c09dbda273d679e2234f
      https://github.com/WebKit/WebKit/commit/a7320ffab3aeadbd0b27c09dbda273d679e2234f
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
    M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  -----------
  [css-grid] Improve GridTrackSizingAlgorithm Architecture
https://bugs.webkit.org/show_bug.cgi?id=277492
rdar://problem/132996992

Reviewed by Alan Baradlay.

We want to hide the setup step inside the run() function. The run() functions requires setup() to be called before executing.
It does not make sense to require the developer to know the setup() function must be called before calling run().

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::run):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeTrackSizesForDefiniteSize):
(WebCore::RenderGrid::computeTrackSizesForIndefiniteSize const):

Canonical link: https://commits.webkit.org/281727@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications