[webkit-changes] [WebKit/WebKit] baea2b: Use SFINAE instead of an IDL attribute to pass a J...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: baea2b903e06bf405e36c9858713553a8fa9fc52
      https://github.com/WebKit/WebKit/commit/baea2b903e06bf405e36c9858713553a8fa9fc52
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-04-25 (Thu, 25 Apr 2024)

  Changed paths:
    M Source/WebCore/bindings/scripts/IDLAttributes.json
    M Tools/DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  Use SFINAE instead of an IDL attribute to pass a JSContextRef to WebKitTestRunner JS callbacks
https://bugs.webkit.org/show_bug.cgi?id=273267
rdar://127068455

Reviewed by Charlie Wolfe.

This will make it easier to add JSContextRef to more functions.
This is similar to how we add a Connection parameter to functions called by IPC in HandleMessage.h
It doesn't work well with static functions or functions with multiple sets of parameters,
so tweaked a few functions to get it to work.

* Source/WebCore/bindings/scripts/IDLAttributes.json:
* Tools/DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
(_generateImplementationFile):
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::domIdentifier const):
(AccessibilityUIElement::liveRegionRelevant const):
(AccessibilityUIElement::liveRegionStatus const):
(AccessibilityUIElement::popupValue const):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(_generateImplementationFile):
* Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::domIdentifier const):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::stringAttributeValueNS const):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValueNS const):
(WTR::AccessibilityUIElement::boolAttributeValueNS const):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSettableNS const):
(WTR::AccessibilityUIElement::liveRegionStatus const):
(WTR::AccessibilityUIElement::liveRegionRelevant const):
(WTR::AccessibilityUIElement::intValue const):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::isAtomicLiveRegion const):
(WTR::AccessibilityUIElement::isBusy const):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired const):
(WTR::AccessibilityUIElement::isFocused const):
(WTR::AccessibilityUIElement::isIndeterminate const):
(WTR::AccessibilityUIElement::isExpanded const):
(WTR::AccessibilityUIElement::currentStateValue const):
(WTR::AccessibilityUIElement::sortDirection const):
(WTR::AccessibilityUIElement::ariaIsGrabbed const):
(WTR::AccessibilityUIElement::isFocusable const):
(WTR::AccessibilityUIElement::isSelectable const):
(WTR::AccessibilityUIElement::hasPopup const):
(WTR::AccessibilityUIElement::popupValue const):
(WTR::AccessibilityUIElement::hasDocumentRoleAncestor const):
(WTR::AccessibilityUIElement::hasWebApplicationAncestor const):
(WTR::AccessibilityUIElement::isInDescriptionListDetail const):
(WTR::AccessibilityUIElement::isInDescriptionListTerm const):
(WTR::AccessibilityUIElement::isInCell const):
(WTR::AccessibilityUIElement::stringAttributeValue const): Deleted.
(WTR::AccessibilityUIElement::numberAttributeValue const): Deleted.
(WTR::AccessibilityUIElement::boolAttributeValue const): Deleted.
(WTR::AccessibilityUIElement::isAttributeSettable const): Deleted.

Canonical link: https://commits.webkit.org/278012@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications