[webkit-changes] [WebKit/WebKit] 730539: HAVE(OS_DARK_MODE_SUPPORT) is unnecessarily restri...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7305395509b2bb10457db40a295ad42504e030ed
      https://github.com/WebKit/WebKit/commit/7305395509b2bb10457db40a295ad42504e030ed
  Author: Tim Horton <thorton at apple.com>
  Date:   2024-04-25 (Thu, 25 Apr 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/page/scrolling/mac/ScrollerMac.mm
    M Source/WebCore/platform/ios/LocalCurrentTraitCollection.h
    M Source/WebCore/platform/ios/LocalCurrentTraitCollection.mm
    M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
    M Source/WebKit/UIProcess/ios/WKPasswordView.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  HAVE(OS_DARK_MODE_SUPPORT) is unnecessarily restrictive
https://bugs.webkit.org/show_bug.cgi?id=273224
rdar://127010330

Reviewed by Wenson Hsieh and Megan Gardner.

* Source/WTF/wtf/PlatformHave.h:
All Cocoa platforms have underlying support for dynamic colors, and WebKit
actually depends on that to correctly paint form controls (e.g. the color
of the check mark in a <input type=checkbox> is labelColor resolved in
dark mode). To make rendering consistent, enable support for our underlying
dynamic color support.

* Source/WebCore/page/scrolling/mac/ScrollerMac.mm:
(-[WebScrollerImpDelegateMac effectiveAppearanceForScrollerImp:]):
* Source/WebCore/platform/ios/LocalCurrentTraitCollection.h:
* Source/WebCore/platform/ios/LocalCurrentTraitCollection.mm:
(WebCore::adjustedTraitCollection):
(WebCore::LocalCurrentTraitCollection::LocalCurrentTraitCollection):
(WebCore::LocalCurrentTraitCollection::~LocalCurrentTraitCollection):
* Source/WebCore/platform/mac/ScrollbarsControllerMac.mm:
(-[WebScrollerImpDelegate effectiveAppearanceForScrollerImp:]):
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _effectiveUserInterfaceLevelIsElevated]):
(scrollViewBackgroundColor):
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::contentViewBackgroundColor):
* Source/WebKit/UIProcess/ios/WKPasswordView.mm:
(-[WKPasswordView showInScrollView:]):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove guards inside Cocoa-only code.

Canonical link: https://commits.webkit.org/278011@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications