[webkit-changes] [WebKit/WebKit] 22e6de: Regression(276851 at main) GPUProcessProxy::sendBookm...

Chris Dumez noreply at github.com
Wed Apr 24 07:36:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22e6debaea7ab722ac27a9ccfa3f7f72a5530b23
      https://github.com/WebKit/WebKit/commit/22e6debaea7ab722ac27a9ccfa3f7f72a5530b23
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-04-24 (Wed, 24 Apr 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm

  Log Message:
  -----------
  Regression(276851 at main) GPUProcessProxy::sendBookmarkDataForCacheDirectory() hangs the main thread
https://bugs.webkit.org/show_bug.cgi?id=273164
rdar://126946636

Reviewed by Per Arne Vollan.

276851 at main started calling GPUProcessProxy::sendBookmarkDataForCacheDirectory() on the main thread
as soon as the GPUProcess finishes launches. The issue is that this function does file system
operations which may hang the UIProcess' main thread. This results in an app launch regression for
certain apps.

To address the issue, I moved the filesystem operation and the IPC to a background queue.

* Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm:
(WebKit::GPUProcessProxy::sendBookmarkDataForCacheDirectory):

Canonical link: https://commits.webkit.org/277923@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list