[webkit-changes] [WebKit/WebKit] 4e0902: REGRESSION (277633 at main): [ MacOS iOS Debug ] Test...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e0902cf80f621c0d596a179bf3c71f4765ebd61
      https://github.com/WebKit/WebKit/commit/4e0902cf80f621c0d596a179bf3c71f4765ebd61
  Author: Geoffrey Garen <ggaren at apple.com>
  Date:   2024-04-24 (Wed, 24 Apr 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/CheckedRef.cpp

  Log Message:
  -----------
  REGRESSION (277633 at main): [ MacOS iOS Debug ] TestWTF.WTF_CheckedPtr.CheckedRef is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=273158
rdar://126954078

Unreviewed test fix.

Removed use after destruction test, since we assert when you do that now.

Changed test objects to be heap-allocated instead of stack-allocated. Stack
allocation wasn't the direct cause of the failure we saw, but CheckedPtr
requires heap allocation as of 277633 at main, so let's do it right.

* Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp:
(TestWebKitAPI::TEST(WTF_CheckedPtr, Basic)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, CheckedRef)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, DerivedClass)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, HashSet)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, ReferenceCountLimit)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, CanMakeThreadSafeCheckedPtr)):
* Tools/TestWebKitAPI/Tests/WTF/CheckedRef.cpp:

Canonical link: https://commits.webkit.org/277922@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications