[webkit-changes] [WebKit/WebKit] 7c2117: [WebXR] Runtime reachability of WebXR IPC endpoints

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c2117c191df17ba95f1b1757ce374c235c27dfa
      https://github.com/WebKit/WebKit/commit/7c2117c191df17ba95f1b1757ce374c235c27dfa
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2024-04-10 (Wed, 10 Apr 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in
    M Source/WebKit/Shared/GPUProcessPreferencesForWebProcess.h
    M Source/WebKit/Shared/GPUProcessPreferencesForWebProcess.serialization.in
    M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h
    M Tools/Scripts/generate-gpup-webgl

  Log Message:
  -----------
  [WebXR] Runtime reachability of WebXR IPC endpoints
https://bugs.webkit.org/show_bug.cgi?id=272438
rdar://121552524

Reviewed by Mike Wyrzykowski.

This change uses [EnabledIf=""] attribute to enable reachability to WebXR
related RemoteGraphicsContextGL IPC endpoints when WebXREnabled preference is
enabled. This allows runtime control over handling of messages, with any
messages received when disabled being dropped.

generate-gpup-webgl has been extended to allow specification of attributes on
the generated messages by adding macro IPC_MESSAGE_ATTRIBUTE(...) between
argument list and `final` keyword in the C++ function prototype. The contents of
IPC_MESSAGE_ATTRIBUTE is copied verbatim as the attribute on the generated
message signature.

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::isWebXREnabled const):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::webXREnabled const):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
* Source/WebKit/Shared/GPUProcessPreferencesForWebProcess.h:
* Source/WebKit/Shared/GPUProcessPreferencesForWebProcess.serialization.in:
* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::preferencesForGPUProcess const):
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
* Tools/Scripts/generate-gpup-webgl:
(cpp_func):
(cpp_func.__init__):
(webkit_ipc_msg):
(webkit_ipc_msg.__init__):
(webkit_ipc_msg.__str__):
(create_cpp_arg_list):
(create_cpp_func):
(main):

Canonical link: https://commits.webkit.org/277361@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications