[webkit-changes] [WebKit/WebKit] 9f5696: [svg] failures in svg/path/property/d-interpolatio...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f56967acd268b43225aad71d19838ec6e4caaaa
      https://github.com/WebKit/WebKit/commit/9f56967acd268b43225aad71d19838ec6e4caaaa
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-04-10 (Wed, 10 Apr 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-004-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-Mm-Aa-Z.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-mM-aA-Z-inverse.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/path/property/d-interpolation-relative-absolute-expected.txt
    M Source/WebCore/svg/SVGPathBlender.cpp
    M Source/WebCore/svg/SVGPathBlender.h

  Log Message:
  -----------
  [svg] failures in svg/path/property/d-interpolation-relative-absolute.html
https://bugs.webkit.org/show_bug.cgi?id=272457

Reviewed by Antti Koivisto.

We failed to reset the current point when processing a "z" commands while blending paths.
This is specified by https://www.w3.org/TR/SVG2/paths.html#PathDataClosePathCommand:

"If a "closepath" is followed immediately by a "moveto", then the "moveto" identifies the
start point of the next subpath. If a "closepath" is followed immediately by any other
command, then the next subpath starts at the same initial point as the current subpath."

This matches the logic implemented by `SVGPathAbsoluteConverter` which also concerns
itself with converting between relative and absolute path commands.

* LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-004-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-Mm-Aa-Z.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-mM-aA-Z-inverse.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/path/property/d-interpolation-relative-absolute-expected.txt:
* Source/WebCore/svg/SVGPathBlender.cpp:
(WebCore::SVGPathBlender::blendMoveToSegment):
(WebCore::SVGPathBlender::blendAnimatedPath):
* Source/WebCore/svg/SVGPathBlender.h:

Canonical link: https://commits.webkit.org/277360@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications