[webkit-changes] [WebKit/WebKit] cbb5cd: Use `HashSet<CheckedRef<Range>>` instead of `WeakH...

Chris Dumez noreply at github.com
Fri Sep 29 17:23:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbb5cdba4811fd1d12b208c90cf2327de50a56ed
      https://github.com/WebKit/WebKit/commit/cbb5cdba4811fd1d12b208c90cf2327de50a56ed
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h

  Log Message:
  -----------
  Use `HashSet<CheckedRef<Range>>` instead of `WeakHashSet<Range>` for Document::m_ranges
https://bugs.webkit.org/show_bug.cgi?id=262407

Reviewed by Brent Fulgham.

Use `HashSet<CheckedRef<Range>>` instead of `WeakHashSet<Range>` for Document::m_ranges.
The Range destructor takes care of removing itself from Document::m_ranges already so we
don't need a WeakPtr. Using CheckedRef here is slightly more efficient.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::updateRangesAfterChildrenChanged):
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):
(WebCore::Document::parentlessNodeMovedToNewDocument):
(WebCore::Document::textInserted):
(WebCore::Document::textRemoved):
(WebCore::Document::textNodesMerged):
(WebCore::Document::textNodeSplit):
* Source/WebCore/dom/Document.h:

Canonical link: https://commits.webkit.org/268680@main




More information about the webkit-changes mailing list