[webkit-changes] [WebKit/WebKit] de3b4d: visionOS: Fix the build for all BaseExtension-deri...

Tim Horton noreply at github.com
Fri Sep 29 17:07:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de3b4d47e4f79fa256c4808bd66691b0312ade25
      https://github.com/WebKit/WebKit/commit/de3b4d47e4f79fa256c4808bd66691b0312ade25
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M Source/WebKit/Configurations/BaseExtension.xcconfig

  Log Message:
  -----------
  visionOS: Fix the build for all BaseExtension-derived targets
https://bugs.webkit.org/show_bug.cgi?id=262414
rdar://116261778

Reviewed by Dean Jackson.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
Don't specify SUPPORTED_PLATFORMS here because:

A) we get it via inheritance

B) this comes *after* we import LocalOverrides (unlike Base.xcconfig, which is *before*),
and thus overrides LocalOverrides' overrides, causing LocalOverrides to be unable to add
the visionOS platform to SUPPORTED_PLATFORMS, and causing Xcode to choose a different
platform to build for, at random (and, notably, one which it did not build the rest of WebKit for).

Canonical link: https://commits.webkit.org/268679@main




More information about the webkit-changes mailing list