[webkit-changes] [WebKit/WebKit] eddbc5: [motion-path] circle() and ellipse() should use no...

Nikos Mouchtaris noreply at github.com
Mon Sep 25 10:14:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eddbc5df03c84c7da6b202923cad6ae71ecc1b0e
      https://github.com/WebKit/WebKit/commit/eddbc5df03c84c7da6b202923cad6ae71ecc1b0e
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-008-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-008.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-ellipse-007-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-ellipse-007.html
    M Source/WebCore/rendering/MotionPath.cpp

  Log Message:
  -----------
  [motion-path] circle() and ellipse() should use non-offset starting position
https://bugs.webkit.org/show_bug.cgi?id=262014
rdar://115962433

Reviewed by Tim Nguyen.

circle() and ellipse() should use non-offset starting position. We don't want to use the offset starting
position as this would make the calculation of the radius size incorrect for circle/ellipse. The one wpt
for circle()/ellipse() do not actually test this properly (they use a 0,0 starting position).

* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-008-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-008.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-ellipse-007-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-ellipse-007.html: Added.
* Source/WebCore/rendering/MotionPath.cpp:
(WebCore::MotionPath::computePathForShape):

Canonical link: https://commits.webkit.org/268400@main




More information about the webkit-changes mailing list