[webkit-changes] [WebKit/WebKit] 59e4fc: WTF::Vector should use ASSERT_WITH_SECURITY_IMPLIC...

Commit Queue noreply at github.com
Mon Sep 25 10:10:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59e4fcd22360629504a67f8f6f992de578ef03c9
      https://github.com/WebKit/WebKit/commit/59e4fcd22360629504a67f8f6f992de578ef03c9
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M Source/WTF/wtf/Assertions.h
    M Source/WTF/wtf/Vector.h

  Log Message:
  -----------
  WTF::Vector should use ASSERT_WITH_SECURITY_IMPLICATION() for buffer/capacity/size checks
https://bugs.webkit.org/show_bug.cgi?id=262043
<rdar://115993707>

Reviewed by Alex Christensen.

* Source/WTF/wtf/Assertions.h:
(ASSERT_NOT_REACHED_WITH_SECURITY_IMPLICATION): Add.

* Source/WTF/wtf/Vector.h:
(WTF::VectorBuffer::endOfBuffer):
(WTF::VectorBuffer::swapInlineBuffers):
(WTF::UnsafeVectorOverflow::overflowed):
(WTF::Vector::uncheckedInitialize):
(WTF::Malloc>::shrink):
(WTF::Malloc>::grow):
(WTF::Malloc>::reserveInitialCapacity):
(WTF::Malloc>::uncheckedAppend):
- Also fix 'size <= capacity' check when adding multiple bytes.
(WTF::Malloc>::appendSlowCase):
(WTF::Malloc>::constructAndAppendSlowCase):
(WTF::Malloc>::uncheckedConstructAndAppend):
(WTF::Malloc>::checkConsistency):

Canonical link: https://commits.webkit.org/268399@main




More information about the webkit-changes mailing list