[webkit-changes] [WebKit/WebKit] 4e5391: Add inter-character annotation placement support

Alan Baradlay noreply at github.com
Sun Sep 24 14:34:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e5391cc59527b7e92ae77d1d9b890b20d1e7e07
      https://github.com/WebKit/WebKit/commit/4e5391cc59527b7e92ae77d1d9b890b20d1e7e07
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-09-24 (Sun, 24 Sep 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  -----------
  Add inter-character annotation placement support
https://bugs.webkit.org/show_bug.cgi?id=262003

Reviewed by Antti Koivisto.

"Each ruby annotation is placed immediately to the right of the relevant ruby base"
https://drafts.csswg.org/css-ruby/#inter-character-layout

* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::setLayoutBoundsForInlineBox const):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::annotationPosition):
(WebCore::Layout::RubyFormattingContext::annotationVerticalExtent):
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationBefore):
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationAfter):
(WebCore::Layout::RubyFormattingContext::annotationExtent): Deleted.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/268374@main




More information about the webkit-changes mailing list