[webkit-changes] [WebKit/WebKit] e9f67f: REGRESSION(268343 at main): Crash under WebCore::Posi...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9f67fe4c9c1a5881942e18067772c28897f6399
      https://github.com/WebKit/WebKit/commit/e9f67fe4c9c1a5881942e18067772c28897f6399
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-09-24 (Sun, 24 Sep 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  -----------
  REGRESSION(268343 at main): Crash under WebCore::PositionedDescendantsMap::removeContainingBlock
https://bugs.webkit.org/show_bug.cgi?id=261998

Reviewed by Chris Dumez.

Some layout tests were crashing under
PositionedDescendantsMap::removeContainingBlock for WinCairo after
268343 at main changed PositionedDescendantsMap::ContainerMap to
WeakHashMap. 'renderer' in removeContainingBlock wasn't a live
RenderBox object in the cases. Previously it has no problem because it
just used a raw pointer as a key.

Changed the key of ContainerMap to const RenderBox*.

* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::PositionedDescendantsMap::addDescendant):
(WebCore::PositionedDescendantsMap::removeDescendant):
(WebCore::PositionedDescendantsMap::removeContainingBlock):

Canonical link: https://commits.webkit.org/268373@main