[webkit-changes] [WebKit/WebKit] db985e: [Filters] Don't override the alpha channel of the ...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db985ec58914e7fe75e5d947e31bcb4f8e82a545
      https://github.com/WebKit/WebKit/commit/db985ec58914e7fe75e5d947e31bcb4f8e82a545
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/GraphicsStyle.cpp
    M Source/WebCore/platform/graphics/GraphicsStyle.h
    M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
    M Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp
    M Source/WebCore/platform/graphics/filters/FEDropShadow.cpp
    M Source/WebCore/rendering/TextPainter.cpp

  Log Message:
  -----------
  [Filters] Don't override the alpha channel of the GraphicsDropShadow color by the shadow opacity
https://bugs.webkit.org/show_bug.cgi?id=261841
rdar://115812347

Reviewed by Cameron McCormack.

The shadow opacity should be applied to GraphicsContext before setting the drop
shadow style. The color of the drop shadow should preserve its alpha channel.

* Source/WebCore/platform/graphics/GraphicsStyle.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/graphics/GraphicsStyle.h:
(WebCore::GraphicsDropShadow::encode const):
(WebCore::GraphicsDropShadow::decode):
* Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::setCGShadow):
* Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:
(WebCore::DrawGlyphsRecorder::updateShadow):
* Source/WebCore/platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::createGraphicsStyle const):
* Source/WebCore/rendering/TextPainter.cpp:

Canonical link: https://commits.webkit.org/268233@main